Don't panic when invalid paths are configured #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the config struct includes invalid output paths, make sure that we don't try to execute a nil function pointer. Fixes #390.
|
Coveralls appears to be hosed somehow; the Coveralls builds themselves are passing, but they're not calling back to GitHub properly to green-light this PR. If code reviewers think this looks okay, I'm going to force-land (as long as Travis builds continue to pass). |
|
This change looks fine to fix the issue in #390, but it seemed a little odd to have this partial return on error. On errors in
I don't think there's any advantages to returning a Take a look at #396 which goes the latter route (we still collect all errors during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config struct includes invalid output paths, make sure that we don't try
to execute a nil function pointer.
Fixes #390.